IBX-691: As a Developer, I want to have reusable popup menu component #1788
Conversation
tischsoic
force-pushed
the
popup-menu-component
branch
from
d18778e
to
3f30fc4
Compare
src/bundle/Resources/views/themes/admin/ui/component/popup_menu/popup_menu.html.twig
Show resolved
Hide resolved
tischsoic
changed the title
tischsoic
force-pushed
the
popup-menu-component
branch
from
e7ec094
to
9750b8f
Compare
| const popupMenuElement = tabsContainer.querySelector('.ibexa-popup-menu'); | ||
|
|
||
| const popupMenu = new eZ.core.PopupMenu({ | ||
| popupMenuElement: popupMenuElement, |
There was a problem hiding this comment.
| popupMenuElement: popupMenuElement, | |
| popupMenuElement, |
| const tabsContainer = popupMenuElement.parentElement; | ||
| const tabsList = tabsContainer.querySelector(SELECTOR_TABS_LIST); | ||
| const tabMore = tabsList.querySelector('.ibexa-tabs__tab--more'); | ||
| const popupMenuAbsoluteLeft = |
There was a problem hiding this comment.
| const popupMenuAbsoluteLeft = | |
| const popupMenuLeftPosition = |
?
| 'items': [], | ||
| }) }} | ||
| {% endif %} | ||
| {% if not hide_toggler|default(false) %} | ||
| <div class="ibexa-tabs__toggler"> | ||
| <span class="ibexa-tabs__toggler-show"> | ||
| {{ 'ui.component.tab.tabs.show'|trans|desc('Show') }} | ||
| {{ 'ui.component.tab.tabs_toggler.show'|trans|desc('Show') }} |
There was a problem hiding this comment.
Shouldn't this be extracted or such key exists?
There was a problem hiding this comment.
I haven't noticed this change. Probably, by a mistake I have forgot to commit it in previous PR, because in xliff it has correct key: https://github.com/ezsystems/ezplatform-admin-ui/pull/1780/files#diff-fc54d07c9121de0ecf10e28736fa4c69f6e811c8f35b03d18f0a11ba1ef6a353R457
| @@ -5,6 +5,12 @@ | |||
| border-radius: $ibexa-border-radius; | |||
| box-shadow: calculateRem(4px) calculateRem(22px) calculateRem(67px) 0 rgba($ibexa-color-info, 0.2); | |||
There was a problem hiding this comment.
Maybe we'll add this style to the variable?
There was a problem hiding this comment.
Currently this shadow is used only here, so I think it should not be extracted as a global variable.
|
Kudos, SonarCloud Quality Gate passed!
|
Popup menu component.
Checklist:
$ composer fix-cs)