IBX-615: As an Editor, I want to see redesigned checkbox and radio buttons in all states #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttons in all states
dew326
requested changes
Jul 6, 2021
| .ibexa-input { | ||
| -webkit-appearance: none; | ||
| -moz-appearance: none; | ||
| appearance: none; |
There was a problem hiding this comment.
not sure if this should be on all inputs or just checkbox/radio
lucasOsti
reviewed
Jul 6, 2021
| -moz-appearance: none; | ||
| appearance: none; | ||
| position: relative; | ||
| display: inline-block; | ||
| outline: none; | ||
| transition: all 0.2s $ibexa-admin-transition; |
There was a problem hiding this comment.
$ibexa-admin-transition-duration
tischsoic
requested changes
Jul 6, 2021
|
|
||
| &:hover { | ||
| border-color: $ibexa-color-primary; | ||
| cursor: pointer; |
There was a problem hiding this comment.
Not every input should have cursor: pointer
|
|
||
| &:active, | ||
| &:focus { | ||
| &:after { |
There was a problem hiding this comment.
Suggested change
| &:after { | |
| &::after { |
ref: https://developer.mozilla.org/en-US/docs/Web/CSS/::after#syntax
tischsoic
reviewed
Jul 6, 2021
|
|
||
| &:active, | ||
| &:focus { | ||
| border-color: $ibexa-color-primary; |
There was a problem hiding this comment.
Not all active inputs have this border colour. Actually, not sure if any? Checkboxes do not have :active state, do they?
tischsoic
reviewed
Jul 6, 2021
|
|
||
| &:disabled { | ||
| opacity: 0.3; | ||
| cursor: default; |
There was a problem hiding this comment.
Suggested change
| cursor: default; | |
| cursor: not-allowed; |
lucasOsti
approved these changes
Jul 7, 2021
added 2 commits
July 7, 2021 10:40
|
Kudos, SonarCloud Quality Gate passed!
|
tischsoic
approved these changes
Jul 7, 2021
dew326
approved these changes
Jul 7, 2021
dew326
deleted the
IBX-615-as-an-editor-i-want-to-see-redesigned-checkbox-and-radio-buttons-in-all-states
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ref: https://issues.ibexa.co/browse/IBX-615
https://github.com/ezsystems/date-based-publisher/pull/227
https://github.com/ezsystems/ezcommerce-admin-ui/pull/92
https://github.com/ezsystems/ezcommerce-shop/pull/323
#1793
https://github.com/ezsystems/ezplatform-calendar/pull/76
https://github.com/ezsystems/ezplatform-form-builder/pull/286
ezsystems/ezplatform-matrix-fieldtype#55
https://github.com/ezsystems/ezplatform-page-builder/pull/777
https://github.com/ezsystems/ezplatform-page-fieldtype/pull/189
https://github.com/ezsystems/ezplatform-personalization/pull/212
https://github.com/ezsystems/ezplatform-segmentation/pull/30
https://github.com/ezsystems/ezplatform-site-factory/pull/126