IBX-612: As an Editor, I want to see redesigned input field in all states #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
force-pushed
the
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
branch
from
92438c6
to
1e0ed5a
Compare
tischsoic
requested review from
GrabowskiM,
lucasOsti and
dew326
and removed request for
GrabowskiM and
lucasOsti
lucasOsti
requested changes
Jul 12, 2021
| .ibexa-form-error { | ||
| display: flex; | ||
| font-family: $font-family-sans-serif; | ||
| font-size: calculateRem(12px); |
There was a problem hiding this comment.
$ibexa-text-font-size-small?
Or maybe you could create some mixin because you repeat 3 time
font-family: $font-family-sans-serif;
font-size: calculateRem(12px);
letter-spacing: 0.12px;
line-height: calculateRem(18px);
There was a problem hiding this comment.
I was thinking about the same. But I'm not sure what I can combine to make it reusable.
Maybe 2 mixins:
- one with: font-family and letter-spacing
- and the other with: font-size and line-height
?
| .ibexa-form-help { | ||
| display: flex; | ||
| font-family: $font-family-sans-serif; | ||
| font-size: calculateRem(12px); |
There was a problem hiding this comment.
$ibexa-text-font-size-small?
| @include label-required(); | ||
|
|
||
| font-family: $font-family-sans-serif; | ||
| font-size: calculateRem(12px); |
There was a problem hiding this comment.
$ibexa-text-font-size-small?
| padding: 0; | ||
| fill: $ibexa-color-dark; | ||
|
|
||
| .ibexa-icon { |
There was a problem hiding this comment.
Maybe modifier in icons.scss ?
tischsoic
force-pushed
the
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
branch
2 times, most recently
from
3635948
to
9be2fb3
Compare
lucasOsti
requested changes
Jul 12, 2021
| @@ -40,10 +40,10 @@ | |||
| } | |||
|
|
|||
| &--text { | |||
| font-family: $font-family-sans-serif; | |||
| @include ibexa-font-sans-serif(); | |||
|
|
|||
| font-size: $small-font-size; | |||
There was a problem hiding this comment.
Please use variable with "ibexa" prefix: $ibexa-text-font-size-small or $ibexa-text-font-size-medium
GrabowskiM
requested changes
Jul 14, 2021
src/bundle/Resources/views/themes/admin/ui/form_fields.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/ui/form_fields.html.twig
Outdated
Show resolved
Hide resolved
tischsoic
force-pushed
the
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
branch
from
88b204e
to
620b228
Compare
lucasOsti
approved these changes
Jul 15, 2021
dew326
requested changes
Jul 15, 2021
tischsoic
force-pushed
the
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
branch
from
46bdd4a
to
2da6f37
Compare
GrabowskiM
approved these changes
Jul 21, 2021
tischsoic
force-pushed
the
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
branch
3 times, most recently
from
75da991
to
c4bab88
Compare
tischsoic
force-pushed
the
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
branch
from
c4bab88
to
9ca8189
Compare
…d ibexa-label--checkbox-radio
tischsoic
force-pushed
the
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
branch
from
9ca8189
to
fec2b02
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
New look
New look --small
Checkbox/radio button labels
Checklist:
$ composer fix-cs)