IBX-580: Added deleted location limitation role access scenario

[micszo]

Question	Answer
Tickets	IBX-580
Bug fix?	no
New feature?	no (new test case)
BC breaks?	no
Tests pass?	yes
Doc needed?	no
License	GPL-2.0

Test checking whether it is possible to access a role that has a policy with a location limitation pointing to a location that has been deleted.

Checklist:

• Coding standards ($ composer fix-cs)
• Ready for Code Review

[micszo]

PR for 3.3: #1800

[mnocon]

The whole Scenario is run as admin, maybe it should not be added to the personas suite and should in included in the Roles.feature file?

Something like:

    Given I create "folder" Content items in root in "eng-GB"
      | name            | short_name      |
      | DeletedLocation | DeletedLocation |
    And I create a role "DeletedLocationRole"
    And I add policy "content" "read" to "DeletedLocationRole" with limitations
      | limitationType | limitationValue  |
      | Location       | /DeletedLocation |
    And I send "/DeletedLocation" to the Trash
    When I am logged as "admin"
    And I go to "Roles" in "Admin" tab
    And I go to "DeletedLocationRole" "Role" page
    Then I should be on "Role" "DeletedLocationRole" page

should work and does not need to be split into two phases (setup & execution).

[micszo]

The whole Scenario is run as admin, maybe it should not be added to the personas suite and should in included in the Roles.feature file?

Something like:

    Given I create "folder" Content items in root in "eng-GB"
      | name            | short_name      |
      | DeletedLocation | DeletedLocation |
    And I create a role "DeletedLocationRole"
    And I add policy "content" "read" to "DeletedLocationRole" with limitations
      | limitationType | limitationValue  |
      | Location       | /DeletedLocation |
    And I send "/DeletedLocation" to the Trash
    When I am logged as "admin"
    And I go to "Roles" in "Admin" tab
    And I go to "DeletedLocationRole" "Role" page
    Then I should be on "Role" "DeletedLocationRole" page

should work and does not need to be split into two phases (setup & execution).

Applied in 3c577d8.

[mnocon]

Looks great, thanks!

[micszo]

PR to 3.3 (#1800) is now updated. Please have a look.

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
4.6% Duplication