IBX-395: Updated code to Bootstrap 5 #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
reviewed
Jul 20, 2021
| @@ -52,7 +52,7 @@ | |||
| const tabLinkId = itemElement.dataset.tabLinkId; | |||
| const tabToShow = tabsList.querySelector(`.ibexa-tabs__link#${tabLinkId}`); | |||
|
|
|||
| $(tabToShow).tab('show'); | |||
| bootstrap.Tab.getOrCreateInstance(tabToShow).show(); | |||
There was a problem hiding this comment.
is window.bootstrap missing here?
dew326
force-pushed
the
bootstrap5
branch
2 times, most recently
from
35ab676
to
a0d92bb
Compare
tischsoic
requested changes
Jul 26, 2021
| @@ -1,4 +1,4 @@ | |||
| (function (global, doc, localStorage, $) { | |||
| (function(global, doc, localStorage) { | |||
There was a problem hiding this comment.
Suggested change
| (function(global, doc, localStorage) { | |
| (function(global, doc, localStorage, bootstrap) { |
lucasOsti
approved these changes
Jul 26, 2021
tischsoic
approved these changes
Jul 26, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ezsystems/ezplatform-personalization/pull/216
ezsystems/ezplatform-search#16
https://github.com/ezsystems/ezplatform-page-builder/pull/794
https://github.com/ezsystems/ezplatform-connector-dam/pull/35
https://github.com/ezsystems/ezplatform-form-builder/pull/293
https://github.com/ezsystems/ezplatform-segmentation/pull/31
https://github.com/ezsystems/ezplatform-site-factory/pull/130
https://github.com/ezsystems/ezplatform-workflow/pull/199
ezsystems/ez-support-tools#100
https://github.com/ezsystems/ezcommerce-admin-ui/pull/95
https://github.com/ezsystems/date-based-publisher/pull/230
ezsystems/ezplatform-admin-ui-assets#28
ibexa/recipes#35
Checklist:
$ composer fix-cs)