IBX-492: As an Editor, I want to see redesigned tables #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
added
Work in progress
Doc needed
tischsoic
force-pushed
the
IBX-492-as-editor-i-want-to-see-redesigned-tables
branch
from
0e64142
to
27e4183
Compare
tischsoic
commented
Jul 28, 2021
| @@ -803,7 +803,7 @@ export default class SubItemsModule extends Component { | |||
| * @param {Object} rawPlaceholdersMap | |||
| */ | |||
| handleBulkOperationFailedNotification(failedItems, modalTableTitle, notificationMessage, rawPlaceholdersMap) { | |||
| const failedItemsData = failedItems.map((content) => ({ | |||
| const failedItemsData = failedItems.map(({ content }) => ({ | |||
There was a problem hiding this comment.
Note: This fixes the broken bulk-delete-failed modal.
lucasOsti
requested changes
Aug 3, 2021
| .replace('{{ content_name }}', contentName) | ||
| .replace('{{ content_type_name }}', contentTypeName) | ||
| .replace('{{ published_date }}', formatShortDateTime(item.ContentInfo.Content.publishedDate)) | ||
| .replace('{{ order }}', selectedItems.length + index + 1); |
There was a problem hiding this comment.
Maybe add selectedItems.length + index + 1 to a variable?
There was a problem hiding this comment.
I just refactored the template. IMO it is outside the scope of this task.
There was a problem hiding this comment.
I have no idea what the author meant.
src/bundle/Resources/views/themes/admin/language/index.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/language/index.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/language/list.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/object_state/object_state_group/list.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/object_state/object_state_group/view.html.twig
Outdated
Show resolved
Hide resolved
GrabowskiM
requested changes
Aug 3, 2021
src/bundle/Resources/views/themes/admin/content/tab/locations/tab.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content/tab/policies/tab.html.twig
Outdated
Show resolved
Hide resolved
| {% set col_raw %} | ||
| {% for language_code in system_url.languageCodes %}{{ ez_admin_ui_config.languages.mappings[language_code].name }}<br>{% endfor %} | ||
| {% endset %} | ||
| {% set body_row_cols = body_row_cols|merge([{ |
There was a problem hiding this comment.
empty line before? To match previous ones (or remove from line 7 and 11)
Also in other places
There was a problem hiding this comment.
I didn't add an empty line here to signify that this merge is related to col_row above.
src/bundle/Resources/views/themes/admin/content/tab/versions/table.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content/tab/versions/table.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/content_type_group/list.html.twig
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
tischsoic
force-pushed
the
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
branch
2 times, most recently
from
9ca8189
to
fec2b02
Compare
tischsoic
commented
Aug 4, 2021
Comment on lines
-106
to
-110
| .table &--name { | ||
| max-width: calculateRem(350px); | ||
| text-overflow: ellipsis; | ||
| overflow: hidden; | ||
| } |
There was a problem hiding this comment.
Note: deleted because it seems that it has never worked - checked on eZ Platform 3.4.
tischsoic
force-pushed
the
IBX-492-as-editor-i-want-to-see-redesigned-tables
branch
from
cc1bd3e
to
e49f9a2
Compare
tischsoic
changed the base branch from
IBX-612-as-editor-i-want-to-see-redesigned-input-field-in-all-states
to
master
tischsoic
force-pushed
the
IBX-492-as-editor-i-want-to-see-redesigned-tables
branch
from
e4a493e
to
6496f5b
Compare
tischsoic
commented
Aug 5, 2021
| &__sort-column { | ||
| position: relative; | ||
| cursor: pointer; | ||
| display: inline-block; |
There was a problem hiding this comment.
Note: this one display: inline-block; is important, it fixes arrow position for multiline header cell:
| before | after |
|---|---|
 |
 |
tischsoic
force-pushed
the
IBX-492-as-editor-i-want-to-see-redesigned-tables
branch
from
742153f
to
16c84d2
Compare
dew326
requested changes
Aug 9, 2021
dew326
approved these changes
Aug 9, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
lucasOsti
approved these changes
Aug 9, 2021
GrabowskiM
approved these changes
Aug 10, 2021
mnocon
pushed a commit
that referenced
this pull request
Oct 20, 2021
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com> (cherry picked from commit d5da1f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Checklist:
$ composer fix-cs)