IBX-836: Redesigned headers #1834
Conversation
mnocon
force-pushed
the
headers
branch
2 times, most recently
from
41c82f7
to
1ed72f8
Compare
src/bundle/Resources/public/js/scripts/sidebar/btn/content.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/sidebar/btn/contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/sidebar/btn/user.edit.js
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,9 @@ | |||
| .ibexa-backdrop { | |||
| position: fixed; | |||
| z-index: 100; | |||
There was a problem hiding this comment.
As far as I remember there are z-indexes highre than 100, isn't it a problem?
There was a problem hiding this comment.
I have checked it in the interface as well as our scss files and z-index: 100 seems to be OK. But in the future, it would be good to have some guidelines etc.
Interestingly, there is ez-backdrop in Page Builder scss and it also has z-index: 100:
https://github.com/ezsystems/ezplatform-page-builder/blob/7ae5586359817c37807d9701adcb474d755013c1/src/bundle/Resources/public/scss/_page-info-bar.scss#L271
src/bundle/Resources/views/themes/admin/content/location_view.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content/location_view.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/content_type_group/create.html.twig
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
| justify-self: start; | ||
| display: flex; | ||
| &__top { | ||
| display: grid; |
There was a problem hiding this comment.
Note for the future because it can be easily overlooked: this grid is set here so that ellipsis works in the title.
Co-authored-by: Jakub Brzegowski <symfiz@gmail.com> Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com> (cherry picked from commit 5b781f5)
Co-authored-by: Jakub Brzegowski <symfiz@gmail.com> Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com> (cherry picked from commit 5b781f5)
Related PRs:
Related Behat PRs:
Checklist:
$ composer fix-cs)