IBX-792: Implemented Field Types Palette #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
force-pushed
the
prototype_field_def_v2
branch
from
450a659
to
f12c85d
Compare
2 tasks
adamwojs
force-pushed
the
prototype_field_def_v2
branch
from
d631715
to
beccc48
Compare
adamwojs
force-pushed
the
prototype_field_def_v2
branch
4 times, most recently
from
3ce1f89
to
f00c6bd
Compare
2 tasks
adamwojs
force-pushed
the
prototype_field_def_v2
branch
3 times, most recently
from
9128305
to
6f29170
Compare
|
@adamwojs there seems to be a problem with notifications regarding CT creation; when a new CT is created (with its own custom name) successfully, then notification appears but with default CT name.
|
GrabowskiM
requested changes
Aug 30, 2021
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/field_definition_placeholder.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/part/field_definition_form.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/part/field_definition_form.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/part/field_definition_form.html.twig
Outdated
Show resolved
Hide resolved
dew326
requested changes
Aug 30, 2021
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
tischsoic
requested changes
Sep 1, 2021
src/bundle/Resources/public/img/empty-field-definition-group.svg
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/ui/component/collapse.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/field_definitions.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/field_definitions.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/edit_base.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/create.html.twig
Outdated
Show resolved
Hide resolved
GrabowskiM
requested changes
Sep 7, 2021
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.relation.default.location.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content/edit_base.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/available_field_types.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content_type/field_definitions_empty_group.html.twig
Outdated
Show resolved
Hide resolved
lucasOsti
force-pushed
the
prototype_field_def_v2
branch
2 times, most recently
from
1e238f7
to
e3876bb
Compare
GrabowskiM
requested changes
Sep 10, 2021
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
lucasOsti
force-pushed
the
prototype_field_def_v2
branch
from
217d1c3
to
c6fc4a5
Compare
alongosz
requested changes
Sep 22, 2021
composer.json
Outdated
| "psr-4": { "EzSystems\\EzPlatformAdminUi\\Tests\\": "src/lib/Tests" } | ||
| "psr-4": { | ||
| "EzSystems\\EzPlatformAdminUi\\Tests\\": "src/lib/Tests", | ||
| "Ibexa\\AdminUi\\Tests\\": "src/lib/Tests" |
There was a problem hiding this comment.
This does not follow package structure requirements.
Suggested change
| "Ibexa\\AdminUi\\Tests\\": "src/lib/Tests" | |
| "Ibexa\\Tests\\AdminUi\\": "tests/lib" |
There was a problem hiding this comment.
Fixed in ae4faf3.
Includes added tests directory to code style configuration & phpunit.xml adjustment.
EDIT: Also btw, the previous exclusion was not working at all :P
alongosz
approved these changes
Sep 22, 2021
| @@ -1,7 +1,7 @@ | |||
| services: | |||
| EzSystems\EzPlatformAdminUiBundle\Controller\: | |||
| resource: "../../Controller/*" | |||
| exclude: "../../Controller/{Controller}" | |||
| exclude: "../../Controller/{FieldDefinitionController.php}" | |||
There was a problem hiding this comment.
TBH I don't like this workaround. I'd rather go for expanding this definition into specific services. It feels like explicitness is more clear and understandable.
This is remark rather for the future, for now let's leave as-is, since it was given as one of the options.
cc @Nattfarinn
There was a problem hiding this comment.
Agreed, but the PR is big as it is, and from what I've seen I'd need to add most of the classes that reside in the subdirectory, which is around ~30 I believe?
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ViniTou new namespaces have been introduced. You'd like to review the code again, or should I dismiss your review? |
ViniTou
approved these changes
Sep 23, 2021
mnocon
approved these changes
Sep 23, 2021
This was referenced Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST endpoints for content type editing
TBD.
ibexa_field_group_namefilteribexa_field_group_namefilter allows to render human readable name of given field group. Usage{{ field.group | ibexa_field_group_name }}TODO:
Checklist:
$ composer fix-cs)