IBX-644: URL Field Type redesign #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
reviewed
Aug 9, 2021
| @@ -42,25 +42,29 @@ | |||
| {%- endblock %} | |||
|
|
|||
| {% block form_row_subfield -%} | |||
| {% set wrapper_class = 'ez-data-source__field ez-data-source__field--' ~ name %} | |||
| {% set wrapper_class = 'ibexa-data-source__field ibexa-data-source__field--' ~ name ~ ' ez-data-source__field ez-data-source__field--' ~ name %} | |||
There was a problem hiding this comment.
Why ez- classes were left? For fields, which are not converted to ibexa- yet?
There was a problem hiding this comment.
Exactly, otherwise all css and js files would have to be adjusted, these classes would have to be removed at the end of refactoring
GrabowskiM
changed the base branch from
IBX-619-as-an-editor-i-want-to-see-the-redesigned-field-types-in-edit-view-mode
to
master
|
Kudos, SonarCloud Quality Gate passed!
|
tischsoic
approved these changes
Aug 9, 2021
dew326
approved these changes
Aug 9, 2021
lucasOsti
approved these changes
Aug 10, 2021
mnocon
pushed a commit
that referenced
this pull request
Oct 20, 2021
(cherry picked from commit f5c48f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)