Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-901: As an Editor, I want to see redesigned alerts #1866

Merged
merged 5 commits into from
Aug 18, 2021

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Aug 18, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-901
Bug fix? no
New feature? no
BC breaks? yes/no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Related PRs:

New design

Screenshot 2021-08-18 at 11 37 40

Screenshot 2021-08-18 at 11 37 51

Screenshot 2021-08-18 at 11 38 03

Screenshot 2021-08-18 at 11 38 30

Subtitle beside

Screenshot 2021-08-18 at 10 54 48

When subtitle beside is too long

Screenshot 2021-08-18 at 10 55 26

New twig template

Now we have a new twig template

{% include '@ezdesign/ui/component/alert/alert.html.twig' with {
    type: 'info',
    title: 'Some title',
    subtitle: 'Some subtitle',
    show_subtitle_beside: true,
    icon_path: ibexa_icon_path('hide'),
    class: 'mb-4',
} only %}

Checklist:

  • Ready for Code Review

@tischsoic tischsoic self-assigned this Aug 18, 2021
@tischsoic tischsoic force-pushed the IBX-901-as-editor-i-want-to-see-redesigned-alerts branch from 7e12f15 to 71f93a2 Compare August 18, 2021 11:11
@DominikaK DominikaK added the Doc needed The changes require some documentation label Aug 18, 2021
@tischsoic tischsoic force-pushed the IBX-901-as-editor-i-want-to-see-redesigned-alerts branch from 71f93a2 to 109a829 Compare August 18, 2021 11:17
@tischsoic tischsoic changed the title IBX-901: Redesign ez-alert (now ibexa-alert) for 4.0 As an Editor, I want to see redesigned alerts Aug 18, 2021
@tischsoic tischsoic changed the title As an Editor, I want to see redesigned alerts IBX-901: As an Editor, I want to see redesigned alerts Aug 18, 2021
@tischsoic tischsoic force-pushed the IBX-901-as-editor-i-want-to-see-redesigned-alerts branch from e2f4ccf to 28e6f12 Compare August 18, 2021 11:43
@tischsoic tischsoic requested a review from dew326 August 18, 2021 11:44
@tischsoic tischsoic requested a review from a team August 18, 2021 11:52
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tischsoic tischsoic removed the request for review from a team August 18, 2021 12:13
@dew326 dew326 merged commit bb08453 into master Aug 18, 2021
@dew326 dew326 deleted the IBX-901-as-editor-i-want-to-see-redesigned-alerts branch August 18, 2021 13:40
@juskora juskora removed the Doc needed The changes require some documentation label Oct 4, 2021
mnocon pushed a commit that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants