Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-920: Redesign pagination #1870

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Aug 24, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-920
Related PR's ezsystems/ezplatform-user#97
ezsystems/ezplatform-search#17
Bug fix? no
New feature? yes
BC breaks? yes
Tests pass? no
Doc needed? ?
License GPL-2.0

Screenshot from 2021-08-24 15-32-19

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti marked this pull request as draft August 24, 2021 07:49
@lucasOsti lucasOsti marked this pull request as ready for review August 24, 2021 13:37
&.disabled {
.page-link:before,
.page-link:after {
border-right-color: $ibexa-color-dark-200;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-right-color: $ibexa-color-dark-200;;
border-right-color: $ibexa-color-dark-200;

.page-link:before,
.page-link:after {
border-right-color: $ibexa-color-dark-200;;
border-bottom-color: $ibexa-color-dark-200;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
border-bottom-color: $ibexa-color-dark-200;;
border-bottom-color: $ibexa-color-dark-200;

@lucasOsti lucasOsti requested a review from dew326 August 25, 2021 07:39
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.0% 2.0% Duplication

@dew326 dew326 merged commit 83e99f3 into ezsystems:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants