IBX-431: Allowed interception of canceling the draft version edit #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nattfarinn
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
damianz5,
alongosz,
ciastektk,
webhdx,
ViniTou and
a team
Nattfarinn
force-pushed
the
ibx-431-lock-and-unlock
branch
from
25d3862
to
19196d8
Compare
adamwojs
requested changes
Aug 30, 2021
src/bundle/Resources/views/themes/admin/content/edit/edit.html.twig
Outdated
Show resolved
Hide resolved
|
@adamwojs Code style is OK, our fixer configuration is outdated (we're not eZ Systems anymore). |
ViniTou
approved these changes
Aug 31, 2021
Nattfarinn
force-pushed
the
ibx-431-lock-and-unlock
branch
from
7c60c82
to
5eb0b5e
Compare
mikadamczyk
approved these changes
Aug 31, 2021
ciastektk
approved these changes
Aug 31, 2021
Nattfarinn
force-pushed
the
ibx-431-lock-and-unlock
branch
from
5eb0b5e
to
ddb5812
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
adamwojs
approved these changes
Aug 31, 2021
micszo
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase with 2.3 after merging:
#1878Done.There cancel button (
X) was a plain link and it was not possible to intercept and react to the action on the backend side.Checklist:
$ composer fix-cs)