IBX-963: Buttons on Trash page are hidden on medium resolutions #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Sep 3, 2021
lucasOsti
requested changes
Sep 6, 2021
| <tr class="ibexa-table__head-row"> | ||
| {% if form is defined %} | ||
| <div class="ibexa-scrollable-wrapper"> | ||
| <table class="ibexa-table table ibexa-table__draft-conflict {{ (is_draft and have_to_paginate ? 'mb-3' : '') }}"> |
There was a problem hiding this comment.
you don't have an ibexa-table parent so i think it should either be ibexa-draft-conflict or ibexa-table--draft-conflict
| {% endif %} | ||
| </tr> | ||
| </thead> | ||
| <tbody |
| {% endfor %} | ||
| </tbody> | ||
| </table> | ||
| </div> |
tischsoic
reviewed
Sep 8, 2021
| class="ibexa-table__body | ||
| {{ table_body_class|default('') -}}" | ||
| {{ html.attributes(table_body_attr|default({})) }} | ||
| <div class="ibexa-scrollable-wrapper"> |
There was a problem hiding this comment.
Do we want to make it an option?
There was a problem hiding this comment.
I don't think so, why not just put it in every table, if it's not needed, there would just be scroll @dew326
There was a problem hiding this comment.
I think you didn't understand me. I was thinking about adding an option for 3rd party to disable with default value true.
lucasOsti
approved these changes
Sep 10, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
tischsoic
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ezsystems/ezplatform-page-builder/pull/827
Checklist:
$ composer fix-cs)