Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1321: [DI] Dropped obsolete Service aliases defined in Kernel #1986

Merged
merged 2 commits into from
Oct 26, 2021
Merged

IBX-1321: [DI] Dropped obsolete Service aliases defined in Kernel #1986

merged 2 commits into from
Oct 26, 2021

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Oct 25, 2021 •
edited

Question Answer
JIRA issue IBX-1321
Requires ezsystems/ezplatform-kernel#253
Type bug
Target Ibexa version v3.3, v4.0
BC breaks no
CI builds Failing: 240512096, Passing: 240575648

This PR drops Symfony service definition aliases used autowiring. They're being moved to ezsystems/ezplatform-kernel via ezsystems/ezplatform-kernel#253 to unblock rebranding of ibexa/core via ibexa/core#5

The service aliases moved:

  • eZ\Publish\Core\MVC\ConfigResolverInterface
  • eZ\Publish\Core\MVC\Symfony\SiteAccess
  • eZ\Publish\Core\Helper\FieldsGroups\FieldsGroupsList
  • eZ\Publish\API\Repository\FieldTypeService (already present in ezplatform-kernel)

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@alongosz alongosz mentioned this pull request Oct 25, 2021
Merged
7 tasks
@alongosz alongosz force-pushed the ibx-1321-drop-obsolete-kernel-svc-aliases branch from 75080f1 to 56f82bf Compare October 26, 2021 09:37
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nattfarinn Nattfarinn merged commit 4f83c50 into 2.3 Oct 26, 2021
@Nattfarinn Nattfarinn deleted the ibx-1321-drop-obsolete-kernel-svc-aliases branch October 26, 2021 12:58
@Nattfarinn
Copy link
Member

@alongosz Remember about merge up and side merge to ibexa org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@ViniTou ViniTou ViniTou approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees
No one assigned
Labels
Bug Work in progress
Milestone
No milestone
6 participants
@alongosz @Nattfarinn @adamwojs @mikadamczyk @Steveb-p @ViniTou