Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2880: Changed CredentialsExpiredListener to expect PasswordExpiredException #2045

Merged
merged 1 commit into from
May 24, 2022
Merged

IBX-2880: Changed CredentialsExpiredListener to expect PasswordExpiredException #2045

merged 1 commit into from
May 24, 2022

Conversation

mateuszbieniek
Copy link
Contributor

@mateuszbieniek mateuszbieniek commented May 17, 2022 •
edited

Question Answer
JIRA issue IBX-2880
Type bug
Target Ibexa version v3.3
BC breaks no

CredentialsExpiredListener expects CredentialsExpiredException which will never happen, as the Exception is immediately replaced with BadCredentialsException in https://github.com/symfony/security-core/blob/5.4/Authentication/Provider/UserAuthenticationProvider.php#L90

This PR adds changes CredentialsExpredListener to expect the PasswordExpiredException exception which extends CustomUserMessageAccountStatusException which allows it to set a proper "password expired" template.

Kernel part of PR: ezsystems/ezplatform-kernel#309

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@mateuszbieniek mateuszbieniek requested a review from a team May 17, 2022 13:00
@mateuszbieniek mateuszbieniek mentioned this pull request May 17, 2022
Merged
5 tasks
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez bogusez self-assigned this May 20, 2022
@adamwojs adamwojs merged commit 0e7cda7 into ezsystems:2.3 May 24, 2022
@mateuszbieniek mateuszbieniek mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@damianz5 damianz5 damianz5 approved these changes

@konradoboza konradoboza konradoboza approved these changes

@bogusez bogusez bogusez approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@bogusez bogusez

Labels
Bug QA approved Ready for MERGE
Milestone
No milestone
8 participants
@mateuszbieniek @Steveb-p @damianz5 @konradoboza @bogusez @adamwojs @mikadamczyk @Nattfarinn