Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2995: Fixed parameters order for AuthenticationSuccessHandler #2051

Merged
merged 1 commit into from
May 27, 2022
Merged

IBX-2995: Fixed parameters order for AuthenticationSuccessHandler #2051

merged 1 commit into from
May 27, 2022

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented May 27, 2022 •
edited

https://issues.ibexa.co/browse/IBX-2955

Source: https://github.com/symfony/symfony/pull/46317/files

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou requested review from a team and mnocon May 27, 2022 08:40
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steveb-p Steveb-p requested a review from a team May 27, 2022 08:41
@konradoboza konradoboza requested a review from a team May 27, 2022 08:41
@ViniTou ViniTou merged commit 157264e into 2.3 May 27, 2022
@ViniTou ViniTou deleted the ibx-2955-fix-auth-success-handler branch May 27, 2022 09:07
@ViniTou ViniTou mentioned this pull request May 30, 2022
Merged
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@ViniTou
IBX-2995: Fixed parameters order for AuthenticationSuccessHandler (#2051
f26df9e 
)

# Conflicts:
#	src/bundle/DependencyInjection/Compiler/SecurityLoginPass.php
#	src/lib/Security/Authentication/RedirectToDashboardAuthenticationSuccessHandler.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@damianz5 damianz5 damianz5 approved these changes

@alongosz alongosz alongosz approved these changes

@mnocon mnocon mnocon approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

Labels
None yet
Milestone
No milestone
9 participants
@ViniTou @adamwojs @mikadamczyk @Steveb-p @damianz5 @alongosz @mnocon @konradoboza @Nattfarinn