Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2964: Flatpickr widget localization #2059

Merged
merged 6 commits into from Aug 22, 2022
Merged

IBX-2964: Flatpickr widget localization #2059

merged 6 commits into from Aug 22, 2022

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Aug 8, 2022 •
edited

Question Answer
Tickets IBX-2964
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

The language will be picked up from the User's Back Office settings.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Aug 8, 2022
@barw4 barw4 requested review from a team August 8, 2022 23:31
@konradoboza
Copy link
Member

It seems the JIRA issue link is wrong.

@barw4 barw4 requested a review from GrabowskiM August 17, 2022 12:45
@barw4 barw4 requested a review from GrabowskiM August 17, 2022 13:28
@konradoboza konradoboza requested a review from a team August 17, 2022 13:50
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3

@mikadamczyk mikadamczyk merged commit 173caf6 into 2.3 Aug 22, 2022
@mikadamczyk mikadamczyk deleted the ibx-2964-flatpickr-intl branch August 22, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@dew326 dew326 Awaiting requested review from dew326

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

@barw4 barw4

Labels
Improvement QA approved Ready for MERGE
Milestone
No milestone
8 participants
@barw4 @konradoboza @mikadamczyk @GrabowskiM @lucasOsti @tomaszszopinski @Nattfarinn @dew326