Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2559: Added new style to ez-extra-actions__content class to allow scrolling language list #2061

Merged
merged 2 commits into from Aug 18, 2022
Merged

IBX-2559: Added new style to ez-extra-actions__content class to allow scrolling language list #2061

merged 2 commits into from Aug 18, 2022

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets IBX-2559
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Added new class to scrolling language lists

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski requested a review from a team August 12, 2022 13:25
@mateuszdebinski mateuszdebinski self-assigned this Aug 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2022 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

GrabowskiM
GrabowskiM approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@GrabowskiM GrabowskiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now PR title isn't correct, as you don't add any new class

@mateuszdebinski mateuszdebinski changed the title IBX-2559: Added new class for scroller language lists IBX-2559: Added new style to ez-extra-actions__content class to allow scrolling language list Aug 17, 2022
@bogusez bogusez self-assigned this Aug 18, 2022
@Nattfarinn Nattfarinn merged commit 4c4e310 into 2.3 Aug 18, 2022
@Nattfarinn Nattfarinn deleted the IBX-2559_language_list_scroll branch August 18, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@bogusez bogusez bogusez approved these changes

@dew326 dew326 Awaiting requested review from dew326

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

@mateuszdebinski mateuszdebinski

@bogusez bogusez

Labels
Bug QA approved Ready for MERGE
Milestone
No milestone
7 participants
@mateuszdebinski @GrabowskiM @dew326 @lucasOsti @bogusez @mikadamczyk @Nattfarinn