Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2588: Sorted mapped languages by priority in content.create widget #2066

Merged
merged 4 commits into from
Sep 14, 2022
Merged

IBX-2588: Sorted mapped languages by priority in content.create widget #2066

merged 4 commits into from
Sep 14, 2022

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Sep 2, 2022 •
edited
Loading

Question Answer
Tickets IBX-2588
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Also, the languages priority has been refactored in UI\Config\Provider as a current site accesses languages config should be prioritized, not just a first language from an array.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested review from a team September 2, 2022 09:16
@barw4 barw4 self-assigned this Sep 2, 2022
@barw4 barw4 removed the request for review from a team September 2, 2022 09:51
@barw4 barw4 changed the title IBX-2588: Sorted mapped languages by priority in UI Config Provider IBX-2588: Sorted mapped languages by priority in content.create widget Sep 2, 2022
@barw4 barw4 requested a review from a team September 5, 2022 08:29
@barw4 barw4 requested a review from dew326 September 5, 2022 10:59
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team September 13, 2022 08:12
@mikadamczyk mikadamczyk merged commit 935180d into 2.3 Sep 14, 2022
@mikadamczyk mikadamczyk deleted the ibx-2588-languages-mappings-priority branch September 14, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@ViniTou ViniTou ViniTou approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@konradoboza konradoboza konradoboza approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

@barw4 barw4

Labels
Bug QA approved Ready for MERGE
Milestone
No milestone
10 participants
@barw4 @mikadamczyk @Steveb-p @GrabowskiM @dew326 @ViniTou @lucasOsti @konradoboza @katarzynazawada @Nattfarinn