Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4125: Updated error level in PagerContentToDataMapper constructor #2088

Merged
merged 1 commit into from
Feb 12, 2023
Merged

IBX-4125: Updated error level in PagerContentToDataMapper constructor #2088

merged 1 commit into from
Feb 12, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Feb 9, 2023 •
edited
Loading

Question Answer
Tickets a follow-up of https://issues.ibexa.co/browse/IBX-4125
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested a review from a team February 9, 2023 12:51
@barw4 barw4 self-assigned this Feb 9, 2023
@barw4 barw4 added Bug and removed Improvement labels Feb 9, 2023
@barw4 barw4 force-pushed the ibx-4125-update-error-level branch from 63269a3 to 9de4d70 Compare February 10, 2023 13:40
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs requested review from mikadamczyk, Nattfarinn and a team February 12, 2023 10:08
@adamwojs
Copy link
Member

Good catch!

@adamwojs adamwojs merged commit 5984562 into 2.3 Feb 12, 2023
@adamwojs adamwojs deleted the ibx-4125-update-error-level branch February 12, 2023 13:15
@adamwojs
Copy link
Member

Could you please merge up changes @barw4 ?

@barw4 barw4 mentioned this pull request Feb 12, 2023
Merged
@barw4
Copy link
Member Author

barw4 commented Feb 13, 2023

@adamwojs will be merged with ibexa/admin-ui#701 together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@konradoboza konradoboza konradoboza approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@barw4 barw4

Labels
Bug Ready for MERGE
Milestone
No milestone
5 participants
@barw4 @adamwojs @konradoboza @mikadamczyk @Nattfarinn