IBX-5053: Handled deleted Locations in UDW-based limitations #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
force-pushed
the
ibx-5053-handle-deleted-location-limitations
branch
from
fb6af47
to
29ef940
Compare
ViniTou
approved these changes
Feb 17, 2023
konradoboza
approved these changes
Feb 21, 2023
|
@barw4 after applying patch im getting this error message: |
|
@ezsystems/javascript-dev-team minor change in JS, so calling in for review: 0bba678 |
|
SonarCloud Quality Gate failed.
|
GrabowskiM
approved these changes
Feb 27, 2023
dew326
approved these changes
Feb 27, 2023
tomaszszopinski
approved these changes
Feb 28, 2023
Gengar-i
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a Location in a Subtree Limitation is not-accessible (because of current user's permissions) policy form will throw an exception and when a Location is deleted form will behave like no values were there in the first place. This can be misleading and lead to broken policies and administrators being unaware that policies were removed after saving a non-touched form (that includes removal of still valid limitations).
Additional information was added to the policy form that a Location is deleted:
Checklist:
$ composer fix-cs)