Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5143: Fixed autosave default value #2093

Merged
merged 1 commit into from
Feb 24, 2023
Merged

IBX-5143: Fixed autosave default value #2093

merged 1 commit into from
Feb 24, 2023

Conversation

reithor
Copy link
Contributor

@reithor reithor commented Feb 22, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5143
Bug fix? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Setting autosave to false via yaml config ( ezsettings.admin_group.autosave.enabled: false ) has no effect.
Autosave is still active.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@reithor reithor marked this pull request as ready for review February 22, 2023 00:37
@reithor reithor requested review from a team and Nattfarinn February 22, 2023 00:38
@ViniTou ViniTou requested a review from a team February 23, 2023 06:33
@konradoboza konradoboza requested a review from a team February 23, 2023 07:09
@mikadamczyk mikadamczyk requested a review from a team February 23, 2023 07:11
@bogusez bogusez self-assigned this Feb 23, 2023
@reithor reithor removed the request for review from a team February 23, 2023 08:46
@mikadamczyk mikadamczyk merged commit 3be546d into 2.3 Feb 24, 2023
@mikadamczyk mikadamczyk deleted the ibx-5143_fixed-autosave-default branch February 24, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@bogusez bogusez bogusez approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@bogusez bogusez

Labels
Bug QA approved Ready for MERGE Ready for review
Milestone
No milestone
6 participants
@reithor @mikadamczyk @ViniTou @konradoboza @bogusez @Nattfarinn