Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28932: Broken empty option design after selecting it from ezselection fieldtype #395

Merged
merged 1 commit into from Mar 19, 2018
Merged

EZP-28932: Broken empty option design after selecting it from ezselection fieldtype #395

merged 1 commit into from Mar 19, 2018

Conversation

sunpietro
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-28932
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

@sunpietro sunpietro self-assigned this Mar 15, 2018
@barbaragr barbaragr self-assigned this Mar 15, 2018
barbaragr
barbaragr requested changes Mar 15, 2018
View reviewed changes
Copy link

@barbaragr barbaragr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2018-03-15 at 11 02 03
This is how it looks like when CI is published. In v1 after publishing in view mode field is empty. Can we do sth about that?

abc
This is how it looks like when multiple choice is checked. Can we put it in one row?

@sunpietro sunpietro force-pushed the ezp-28932-fix-selection-fieldtype branch 3 times, most recently from 8e52519 to 06868d1 Compare March 19, 2018 08:38
@sunpietro
Copy link
Contributor Author

ping @dew326 @barbaragr
Please, test with long text examples in the options labels.

@sunpietro sunpietro force-pushed the ezp-28932-fix-selection-fieldtype branch from 06868d1 to 727b426 Compare March 19, 2018 11:18
@barbaragr
Copy link

barbaragr commented Mar 19, 2018 •
edited

If I had two the same options, for example: abc, only one of them is show in creation form. Should we allow user to add identical options then?
screen shot 2018-03-19 at 12 43 42

screen shot 2018-03-19 at 12 44 00

@sunpietro
Copy link
Contributor Author

@barbaragr I believe it's a question to PMs. Currently, it's out of scope of this PR.
cc @SylvainGuittard

@SylvainGuittard
Copy link
Contributor

Regarding identical options, I agree with @sunpietro: it's out of scope of this PR.
I think not allowing the user to use the identical labels for option is a good idea. I also don't think this will happen in a real use case. So, no need for a follow up story.

@sunpietro sunpietro merged commit 818005b into master Mar 19, 2018
@sunpietro sunpietro deleted the ezp-28932-fix-selection-fieldtype branch March 19, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@barbaragr barbaragr barbaragr approved these changes

@lserwatka lserwatka Awaiting requested review from lserwatka

Assignees

@sunpietro sunpietro

@barbaragr barbaragr

Labels
Bug QA approved Ready for review
Milestone
No milestone
4 participants
@sunpietro @barbaragr @SylvainGuittard @dew326