Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28955: Adding pagination to URL Aliases in the URL alias tab #436

Merged
merged 1 commit into from Apr 5, 2018
Merged

EZP-28955: Adding pagination to URL Aliases in the URL alias tab #436

merged 1 commit into from Apr 5, 2018

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Mar 30, 2018 •
edited

Question Answer
Tickets https://jira.ez.no/browse/EZP-28955
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

mikadamczyk
mikadamczyk approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@mikadamczyk mikadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about naming. In the rest of a code we have a pager, not paginator. I think it is a good idea to move the pagination to separate template, as you do it.

@ViniTou
Copy link
Contributor Author

ViniTou commented Mar 30, 2018

Truth spoken about naming, going to change it.

@ViniTou ViniTou force-pushed the EZP-28955-url-alias-pagination branch from 79ca168 to 0a8e13d Compare March 30, 2018 13:44
@ViniTou ViniTou changed the base branch from master to 1.1 March 30, 2018 13:44
@webhdx
Copy link
Contributor

webhdx commented Apr 4, 2018

The question about templates and BC policy comes back - in theory if anyone decided to override the templates by this PR their changes will no longer work as you renamed src/bundle/Resources/views/content/tab/urls.html.twig to src/bundle/Resources/views/content/tab/url/tab.html.twig.

Can you do the change without moving files?

@ViniTou ViniTou force-pushed the EZP-28955-url-alias-pagination branch from 0a8e13d to 42def59 Compare April 5, 2018 07:24
@ViniTou
Copy link
Contributor Author

ViniTou commented Apr 5, 2018

@webhdx
renamed

@barbaragr

@lserwatka lserwatka merged commit 503d6c6 into ezsystems:1.1 Apr 5, 2018
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@adamwojs
Merge pull request #436 from ibexa/merge-ibx-2880
39ca3b3 
IBX-2880: Changed CredentialsExpiredListener to expect PasswordExpiredException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@barbaragr barbaragr barbaragr approved these changes

@webhdx webhdx Awaiting requested review from webhdx

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@barbaragr barbaragr

Labels
QA approved
Milestone
No milestone
5 participants
@ViniTou @webhdx @mikadamczyk @barbaragr @lserwatka