EZP-28890: Added crowdin in-context translation JS code #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
commented
Jun 4, 2018
| @@ -34,6 +34,13 @@ | |||
| </script> | |||
| <script src="/bundles/fosjsrouting/js/router.js"></script> | |||
| <script src="{{ path('fos_js_routing_js', { callback: 'fos.Router.setData' }) }}"></script> | |||
| {% if app.request.locale == 'ach_UG' %} | |||
There was a problem hiding this comment.
This could be abstracted so that the way to detect in-context isn't bound to the implementation (if app.in_context_translation_enabled).
| @@ -34,6 +34,13 @@ | |||
| </script> | |||
| <script src="/bundles/fosjsrouting/js/router.js"></script> | |||
| <script src="{{ path('fos_js_routing_js', { callback: 'fos.Router.setData' }) }}"></script> | |||
| {% if app.request.locale == 'ach_UG' %} | |||
| <script type="text/javascript"> | |||
There was a problem hiding this comment.
This could/should be moved to the bottom of the file. It could also be added by an external file, as it is supported by the template. Pointers appreciated.
|
Ping @sunpietro @dew326. This needs to move forward guys :) Without it, no in-context. |
bdunogier
force-pushed
the
ezp28890-crowdin_in_context_js
branch
from
7a29230
to
f048f88
Compare
lserwatka
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for in-context translation, as introduced in ezsystems/PlatformUIBundle#773.
Checklist:
ezplatform. It would allow usage of in-context for any 3rd party bundle.$ composer fix-cs)