EZP-29119: Display proper validation error message when non-image file uploaded in image FieldType #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
By overriding |
adamwojs
approved these changes
Jun 15, 2018
sunpietro
reviewed
Jun 15, 2018
| {% set label = name|humanize %} | ||
| {%- endif -%} | ||
| {%- endif -%} | ||
| <{{ element|default('label') }}{% if label_attr %}{% with { attr: label_attr } %}{{ block('attributes') }}{% endwith %}{% endif %}>{{ translation_domain is same as(false) ? label : label|trans({}, translation_domain) }}{% block form_label_errors %}{{- form_errors(form) -}}{% endblock form_label_errors %}</{{ element|default('label') }}> |
There was a problem hiding this comment.
I think it exceeds 140 chars per line, isn't it?
mikadamczyk
force-pushed
the
EZP-29119
branch
2 times, most recently
from
089bb98
to
1befe3b
Compare
micszo
reviewed
Jun 15, 2018
micszo
approved these changes
Jun 15, 2018
mikadamczyk
force-pushed
the
EZP-29119
branch
2 times, most recently
from
0179a55
to
0179bcb
Compare
|
@micszo re-test is needed here. |
|
This PR affect all field types, especially compound fields |
|
On eZ Platform EE demo v2.2.0-beta1 with patch from this diff console error occurs when uploading PHP file in Image: "Uncaught TypeError: Cannot read property 'innerHTML' of null". |
|
@micszo ready for re-test. |
|
@mikadamczyk please merge it up |
mateuszdebinski
pushed a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: katarzynazawada <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is also fixing doubled error messages (backend).
Checklist:
$ composer fix-cs)