Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29182/EZP-29187: Adjust tests for UDW selection changes #579

Merged
merged 1 commit into from Jul 26, 2018
Merged

EZP-29182/EZP-29187: Adjust tests for UDW selection changes #579

merged 1 commit into from Jul 26, 2018

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Jul 26, 2018

Question Answer
Tickets Part of https://jira.ez.no/browse/EZP-29187, https://jira.ez.no/browse/EZP-29182
Bug fix? no
New feature? no
BC breaks? no
Tests pass? should
Doc needed? no
License GPL-2.0

ezsystems/ezplatform-admin-ui-modules#94 changed the way items are selected in UDW - there is no longer a "Select content" button, but individual "add" buttons for each UDW item if UDW is in multiselect mode. For single mode, there is no "select content" button - selecting and confirming is enough. This PR adjust tests for that fact.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ezsystems ezsystems deleted a comment from ezrobot Jul 26, 2018
@ezsystems ezsystems deleted a comment from ezrobot Jul 26, 2018
@ezsystems ezsystems deleted a comment from ezrobot Jul 26, 2018
@mnocon mnocon requested a review from m-tyrala July 26, 2018 13:01
@mnocon mnocon changed the title [WIP] EZP-29182/EZP-29187: Adjust tests for UDW selection changes EZP-29182/EZP-29187: Adjust tests for UDW selection changes Jul 26, 2018
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lserwatka lserwatka merged commit 1f27a88 into ezsystems:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants