-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-27901: As an Editor, I want to edit a DateAndTime field type with the new UI guidelines #62
Conversation
269bbf2
to
017bc2b
Compare
Backend part is now finished: ezsystems/repository-forms#171 |
const datetimeConfig = { | ||
defaultDate: new Date(), | ||
enableTime: true, | ||
enableSeconds: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enableSeconds
should come from backend. In fieldType you can specify if field should use seconds.
pickrInput.type = 'text'; | ||
pickrInput.classList.add('flatpickr', 'flatpickr-input', 'ez-data-source__input', 'form-control'); | ||
|
||
sourceInput.hidden = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be done in backend while rendering field? //cc @webhdx
|
||
sourceInput.hidden = true; | ||
|
||
sourceInput.parentNode.insertBefore(pickrInput, sourceInput); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this whole rendering additional input should be on backend in twig I think
03bf9b3
to
8e2522a
Compare
|
||
const datetimeFields = [...document.querySelectorAll(SELECTOR_FIELD)]; | ||
const datetimeConfig = { | ||
defaultDate: new Date(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about edit mode or when the field will have default value?
8fd6962
to
f420c60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no "required" validation when field loses focus.
@m-tyrala the date/datetime/time field doesn't work this way. They don't use focus at all. |
f420c60
to
62612e3
Compare
Here is what is written inside JIRA ticket:
So i requested to change this, if this description is wrong, then no problem. |
@m-tyrala you are right, could you make a bug in JIRA as a followup and paste is here? |
…n-table-header EZP-27952: Sub-items table - Incorrect number displayed in the table header
THINGS DONE: