EZP-29650: Fix Selection field (Content Type fields) arrow color #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Oct 3, 2018
| @@ -3,7 +3,7 @@ | |||
| position: relative; | |||
| color: $ez-color-base-dark; | |||
| font-weight: 700; | |||
| cursor: pointer; | |||
| cursor: initial; | |||
There was a problem hiding this comment.
Do we need initial? Cannot we just remove it?
There was a problem hiding this comment.
If you don't need it, then remove it.
There was a problem hiding this comment.
It overrides: .ez-field-edit--ezselection .ez-data-source which has cursor: pointer;.
There was a problem hiding this comment.
So, maybe you should fix it there, hm?
There was a problem hiding this comment.
I didn't want to break something.
There was a problem hiding this comment.
ez-custom-dropdown comes from ezselection fieldtype. You can remove it safely.
sunpietro
suggested changes
Oct 3, 2018
| @@ -3,7 +3,7 @@ | |||
| position: relative; | |||
| color: $ez-color-base-dark; | |||
| font-weight: 700; | |||
| cursor: pointer; | |||
| cursor: initial; | |||
There was a problem hiding this comment.
If you don't need it, then remove it.
tischsoic
force-pushed
the
EZP-29650-content-type-fields-selection-field-UI-issues
branch
from
e260774
to
b02fa7c
Compare
|
ping @sunpietro |
sunpietro
approved these changes
Oct 4, 2018
lserwatka
deleted the
EZP-29650-content-type-fields-selection-field-UI-issues
branch
ViniTou
pushed a commit
that referenced
this pull request
May 12, 2023
* Added getElement method * Added getCell method Co-authored-by: katarzynazawada <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1. problem - pointer cursor.
2. problem was fixed in: #648 by the by of other task.
Previous PR to this task was closed: #644.
More info in JIRA.
Checklist:
$ composer fix-cs)