Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30308: User menu changes width depending on user name length #908

Merged
merged 2 commits into from
Mar 19, 2019
Merged

EZP-30308: User menu changes width depending on user name length #908

merged 2 commits into from
Mar 19, 2019

Conversation

tischsoic
Copy link
Contributor

Question Answer
Tickets https://jira.ez.no/browse/EZP-30308
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

After fix:

Screen Shot 2019-03-18 at 08 10 56

@tischsoic tischsoic self-assigned this Mar 18, 2019
@tischsoic tischsoic requested a review from dew326 March 18, 2019 12:16
@tischsoic tischsoic changed the title EZP-30308: Fix user menu width EZP-30308: User menu changes width depending on user name length Mar 18, 2019
@barbaragr barbaragr self-assigned this Mar 18, 2019
@barbaragr
Copy link

For really short username user menu still changes its width a little. Are we ok with that?
Screen Shot 2019-03-18 at 16 42 35

@lserwatka
Copy link
Member

We can set some min width so that all labels remains in a single line.

@tischsoic
Copy link
Contributor Author

I missed this, I've added white-space: nowrap. ping @barbaragr 🙂
Screen Shot 2019-03-19 at 04 07 12

@lserwatka lserwatka merged commit c538e51 into 1.4 Mar 19, 2019
@lserwatka lserwatka deleted the EZP-30308-user-menu-changes-width-depending-on-user-name-lenght branch March 19, 2019 09:11
@tischsoic
Copy link
Contributor Author

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@barbaragr barbaragr barbaragr approved these changes

Assignees

@tischsoic tischsoic

@barbaragr barbaragr

Labels
Bug QA approved
Milestone
No milestone
4 participants
@tischsoic @barbaragr @lserwatka @dew326