eZ Platform v3 compatibility

[kmadejski]

This PR brings compatibility for eZ Platform v3. Due to introduced changes it should be released under a different major tag as it's no longer compatible with eZ Platform v2.x and lower.

[adamwojs]

Major version release it's a good opportunity to clean up the code base. Quick self-check list:

• Consider to mark classes as final if it's possible (usually controllers, compiler passes etc.)
• Apply official code style (import them from ezplatform-code-style)
• Drop deprecated classes/methods/properties

[adamwojs]

symfony/** dependencies are missing

[kmadejski]

@adamwojs commits from 239ba3d contain changes you have requested. I did it according to my best knowledge, but some things might still be missing.
It must be released under a new major version as there are changes (added missing return types) on the interfaces.

@lserwatka could we have a QA certification on this one, please?

[kmadejski]

@bdunogier / @damianz5 any feedback on this one, please?

[arfaram]

@kmadejski The trait class RepositoryAware.php is removed. The use will cause exception

[kmadejski]

That's right, just got it from QA as well. I'll fix it soon :)

[micszo]

Hi @kmadejski ! Thanks for fixing the RepositoryAware issue. 😎

It's now possible to use this new feature on 3.0, below please find the non-blocking things I noticed.

On the UI the checkbox seems to need some more love, unless I'm missing some assets but I tried reloading translations, yarn etc.:

In the browser console an error occurs when creating a new translation, it looks a bit different on Chrome and Firefox.

FF:

TypeError: mapping is undefined

Chrome:

Uncaught TypeError: Cannot read property 'google' of undefined

I'll let you know if I find anything else.

[micszo]

What about support for Landing Pages? 🙂 e.g. some text in a Code block. The checkbox is visible when adding a translation from Page Builder level but the magic doesn't happen.

[kmadejski]

@micszo unfortunately, it does not support Landing Pages but it could be a nice improvement 🙂

[micszo]

Ok, similarly the option is present when adding translations in Form Builder. 🙂 But here it could be only applicable to placeholder values I suppose.

[kmadejski]

@micszo I have identifier the root source of the problem you spot during recent tests. There is a problem with template overriding. This bundle tries to override one of the templates, precisely admin/content/modal/add_translation.html.twig ( https://github.com/ezsystems/ezplatform-automated-translation/blob/v3/bundle/Resources/views/themes/admin/content/modal/add_translation.html.twig) which is necessary to display a switcher (checkbox).
Since this happens within the same theme, admin, the template precedence order is taken from bundles list order defined in bundles.php. I'm unsure if this behavior is completely correct, but it is what it is. To make it work, you need to change bundles order in bundles.php and move EzSystems\EzPlatformAutomatedTranslationBundle\EzPlatformAutomatedTranslationBundle::class => ['all' => true], before EzSystems\EzPlatformAdminUiBundle\EzPlatformAdminUiBundle::class => ['all' => true],.

I have updated bundle's documentation to cover this trick in: 1b7e543

[bdunogier]

I'm not surprised by the behaviour you describe, @kmadejski. I'm afraid it is "correct", as in "not a side effect", but it doesn't feel right from a user perspective. I don't know what we could do about it, but it would be great if we could find a better way than fiddling with bundles order.

[micszo]

@kmadejski changing bundles order resolves the problem on v3.0.6. 👍
Should it also work for v3.1.0?
With the same setup I can't get it to work on 3.1.

Update: on v3.1.1 changing order works.

[kmadejski]

@micszo I was testing this on v3.1.0 and it seems to be alright. What is the issue you're facing?

[micszo]

Yesterday on v3.1.0 the order change had no effect for me but now on v3.1.1 it works fine. Not sure what was the issue.

[kmadejski]

@micszo Just guessing that it could be cache 😅 Thanks for testing!