Skip to content
This repository has been archived by the owner on Mar 18, 2021. It is now read-only.

COM-19890: Implement the footer #12

Merged
merged 2 commits into from
Aug 29, 2016

Conversation

SylvainGuittard
Copy link
Collaborator

jira issue: https://jira.ez.no/browse/COM-19890

Improvements

  • Added Fontawesome
  • Added doc links (Layout content type field)
  • Implemented the final design

Desktop

ezplatform-footer

iPhone

ezplatform-footer-iphone

@SylvainGuittard
Copy link
Collaborator Author

ping @clash82 @damianz5

@@ -24,6 +24,19 @@
href="{{ asset('assets/images/favicon.ico') }}"
type="image/x-icon" />

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous">

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for what do you need this line? :)

@SylvainGuittard SylvainGuittard force-pushed the COM-19890-footer branch 2 times, most recently from 7dbfc1e to 0fb346c Compare August 29, 2016 13:09
@@ -25,6 +25,7 @@
type="image/x-icon" />

<link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove https:

@damianz5
Copy link
Contributor

+1

@clash82
Copy link
Contributor

clash82 commented Aug 29, 2016

Could you please try http://www.scriptcompress.com/SVG-minifier.htm for SVG files? I've discovered it few days ago and I must say it's really good. This tool can produce one-liner SVG's.

Besides that +1

@SylvainGuittard
Copy link
Collaborator Author

SylvainGuittard commented Aug 29, 2016

Could you please try http://www.scriptcompress.com/SVG-minifier.htm for SVG files?

For this kind of files, I don't think it's useful. See the results:
Original file size: 1.7 kB
Optimized file size: 1.6 kB (92.4%)

Second point, remember the issue we had with Firefox on ez.no. Don't want to take the risk.

@SylvainGuittard SylvainGuittard merged commit ca8dfbb into ezsystems:master Aug 29, 2016
@clash82
Copy link
Contributor

clash82 commented Aug 30, 2016

For this kind of files, I don't think it's useful. See the results:
Original file size: 1.7 kB
Optimized file size: 1.6 kB (92.4%)

Second point, remember the issue we had with Firefox on ez.no. Don't want to take the risk.

The idea behind this minifier was to reduce file size and remove unneeded metadata.
I was using it to fix the issues with Firefox :(

@SylvainGuittard
Copy link
Collaborator Author

The idea behind this minifier was to reduce file size and remove unneeded metadata.
I was using it to fix the issues with Firefox :(

OK, I will create a new issue, and we'll use this tool for all the svg files ;)

@SylvainGuittard
Copy link
Collaborator Author

svg file compression: https://jira.ez.no/browse/COM-19900

@clash82
Copy link
Contributor

clash82 commented Aug 31, 2016

ok, great :)

@SylvainGuittard SylvainGuittard deleted the COM-19890-footer branch September 16, 2016 21:46
damianz5 pushed a commit to damianz5/ezplatform-com that referenced this pull request Nov 20, 2018
Replace demo bundle by studio demo bundle
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants