This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
COM-20065: Implement card view for bundle list #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
force-pushed
the
COM-20065-implement-card-view-for-bundle-list
branch
from
46b57e8
to
c86dcba
Compare
SylvainGuittard
suggested changes
Nov 9, 2018
app/Resources/views/themes/ezplatform/line/bundle_card.html.twig
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,54 @@ | |||
| <div class="bundle-card-line-container{% if extra.page is defined %} page-{{ extra.page }}{% endif %}"> | |||
There was a problem hiding this comment.
I don't think this file should be in this PR ;)
There was a problem hiding this comment.
Nikita wants to keep old template in repository
There was a problem hiding this comment.
This is why we have git. So we can restore the previous version of the file if we need to.
There is no need to keep an unused file in the repo.
There was a problem hiding this comment.
Ok, I removed this template
ciastektk
force-pushed
the
COM-20065-implement-card-view-for-bundle-list
branch
2 times, most recently
from
7c52c0f
to
c28f90b
Compare
damianz5
approved these changes
Nov 14, 2018
ciastektk
force-pushed
the
COM-20065-implement-card-view-for-bundle-list
branch
from
c28f90b
to
f834612
Compare
SylvainGuittard
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Approved! Thanks @ciastektk
(if you can fix my last comment, that would be great)
Co-Authored-By: ciastektk <tomasz.kryszan@ez.no>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/COM-20065