This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
COM-20077-GA-event-doesnt-work #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
from
9904177
to
ae02081
Compare
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
7 times, most recently
from
36dd551
to
2d1c1c9
Compare
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
3 times, most recently
from
f304209
to
7514c51
Compare
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
from
7514c51
to
bf4e774
Compare
SylvainGuittard
approved these changes
Dec 11, 2018
sunpietro
suggested changes
Dec 12, 2018
app/Resources/views/themes/ezplatform/line/bundle_card.html.twig
Outdated
Show resolved
Hide resolved
app/Resources/views/themes/ezplatform/line/bundle_card.html.twig
Outdated
Show resolved
Hide resolved
app/Resources/views/themes/ezplatform/line/bundle_card.html.twig
Outdated
Show resolved
Hide resolved
app/Resources/views/themes/ezplatform/row/download_section.html.twig
Outdated
Show resolved
Hide resolved
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
2 times, most recently
from
d7bf42a
to
341a5e7
Compare
dew326
suggested changes
Dec 13, 2018
web/assets/js/GoogleAnalyticsItem.js
Outdated
| @@ -0,0 +1,12 @@ | |||
| class GoogleAnalyticsItem { | |||
|
|
|||
| constructor(hitType = 'event', eventCategory, eventAction, eventLabel = null, transport = {}) { | |||
There was a problem hiding this comment.
I agree with @sunpietro. This is should be an object or map, not a class.
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
2 times, most recently
from
8245197
to
93590a6
Compare
|
@sunpietro, @dew326 many thanks for your help! I provided changes requested by you. Can you check them? |
dew326
reviewed
Dec 14, 2018
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
3 times, most recently
from
8edac06
to
d5bc942
Compare
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
from
d5bc942
to
bb84a4e
Compare
ciastektk
force-pushed
the
COM-20077-GA-event-doesnt-work
branch
from
bb84a4e
to
e15f5f5
Compare
|
@dew326 can you check the new changes? |
dew326
approved these changes
Dec 18, 2018
|
@sunpietro, do you have other suggestions? |
sunpietro
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/COM-20077