IBX-902: Refactored GroupedFields as a separate service #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianz5
force-pushed
the
IBX-902-cotf-field-tabs
branch
5 times, most recently
from
3aaef07
to
e3adb48
Compare
damianz5
changed the title
2 tasks
Steveb-p
requested changes
Sep 6, 2021
src/contracts/Content/Form/Provider/GroupedContentFormFieldsProviderInterface.php
Outdated
Show resolved
Hide resolved
src/lib/Content/Form/Provider/GroupedContentFormFieldsProvider.php
Outdated
Show resolved
Hide resolved
src/lib/Content/Form/Provider/GroupedContentFormFieldsProvider.php
Outdated
Show resolved
Hide resolved
Comment on lines
+120
to
+122
| 'grouped_fields' => $this->groupedContentFormFieldsProvider->getGroupedFields( | ||
| $form->get('fieldsData')->all() | ||
| ), |
There was a problem hiding this comment.
TBH while it's a change to initial implementation, I believe that probably AbstractType::buildView() from the Form component should have been used instead for grouping data for the form. After all, how fields are grouped should be part of the form itself, not part of a view.
Just a note though. Optional.
tests/lib/Content/Form/Provider/GroupedContentFormFieldsProviderTest.php
Outdated
Show resolved
Hide resolved
tests/lib/Content/Form/Provider/GroupedContentFormFieldsProviderTest.php
Outdated
Show resolved
Hide resolved
tests/lib/Content/Form/Provider/GroupedContentFormFieldsProviderTest.php
Outdated
Show resolved
Hide resolved
tests/lib/Content/Form/Provider/GroupedContentFormFieldsProviderTest.php
Show resolved
Hide resolved
tests/lib/Content/Form/Provider/GroupedContentFormFieldsProviderTest.php
Outdated
Show resolved
Hide resolved
Steveb-p
reviewed
Sep 6, 2021
src/contracts/Content/Form/Provider/GroupedContentFormFieldsProviderInterface.php
Outdated
Show resolved
Hide resolved
Steveb-p
reviewed
Sep 6, 2021
src/lib/Content/Form/Provider/GroupedContentFormFieldsProvider.php
Outdated
Show resolved
Hide resolved
damianz5
force-pushed
the
IBX-902-cotf-field-tabs
branch
from
370f667
to
a694752
Compare
webhdx
approved these changes
Sep 7, 2021
adamwojs
approved these changes
Sep 7, 2021
mikadamczyk
approved these changes
Sep 7, 2021
Steveb-p
reviewed
Sep 7, 2021
src/lib/Content/Form/Provider/GroupedContentFormFieldsProvider.php
Outdated
Show resolved
Hide resolved
damianz5
force-pushed
the
IBX-902-cotf-field-tabs
branch
from
d2f50a1
to
0d10794
Compare
Steveb-p
approved these changes
Sep 7, 2021
tests/lib/Content/Form/Provider/GroupedContentFormFieldsProviderTest.php
Outdated
Show resolved
Hide resolved
damianz5
force-pushed
the
IBX-902-cotf-field-tabs
branch
from
0d10794
to
ad13bc9
Compare
alongosz
approved these changes
Sep 7, 2021
Merged
damianz5
force-pushed
the
IBX-902-cotf-field-tabs
branch
from
ad13bc9
to
a4831a7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
tomaszszopinski
approved these changes
Sep 10, 2021
|
@damianz5 Please merge up to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored GroupedFields as a separate service.
Checklist:
$ composer fix-cs)