Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1063: Added support for multiple field errors #49

Merged
merged 1 commit into from
Oct 11, 2021
Merged

IBX-1063: Added support for multiple field errors #49

merged 1 commit into from
Oct 11, 2021

Conversation

SerheyDolgushev
Copy link
Contributor

Related to ezsystems/ezplatform-kernel#235. As the validator might return an array of errors, but not only a single error.

@webhdx
Copy link
Contributor

webhdx commented Sep 17, 2021

Hello @SerheyDolgushev
Thanks for the contribution. I've read the ticket but did you manage to find minimal steps to reproduce the issue? Content editing is where we need to be extra cautious when introducing changes. I'd like to possibly have a good real case test scenario where it fails before I do a code review.

@SerheyDolgushev
Copy link
Contributor Author

SerheyDolgushev commented Sep 17, 2021 •
edited
Loading

@webhdx Please check https://issues.ibexa.co/browse/IBX-1063 (i just added steps to reproduce). And if you review submitted PRs it is obvious there is something wrong. Specially ezsystems/ezplatform-kernel#235.

@micszo micszo self-assigned this Sep 24, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SerheyDolgushev SerheyDolgushev mentioned this pull request Oct 8, 2021
Merged
6 tasks
micszo
micszo approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ezsystems/ezplatform-kernel#235.

@micszo micszo removed their assignment Oct 11, 2021
@webhdx webhdx merged commit 22e7233 into ezsystems:1.3 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webhdx webhdx webhdx approved these changes

@micszo micszo micszo approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
3 participants
@SerheyDolgushev @webhdx @micszo