IBX-4796: Proper redirect after content publish #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
reviewed
Jan 30, 2023
konradoboza
approved these changes
Jan 30, 2023
webhdx
approved these changes
Feb 1, 2023
ciastektk
approved these changes
Feb 1, 2023
ViniTou
approved these changes
Feb 1, 2023
ViniTou
reviewed
Feb 1, 2023
There was a problem hiding this comment.
It seems, that failing browser test is relevant, could you try to reproduce it in UI?
Scenario: Create a folder without a draft # vendor/ezsystems/ezplatform-content-forms/features/ContentEdit/create_without_draft.feature:6
Given that I have permission to create folders # EzSystems\EzPlatformContentForms\Behat\Context\ContentEditContext::thatIHavePermissionToCreateFolders()
And there is a Content Type "folder" with the id "1" # EzSystems\EzPlatformContentForms\Behat\Context\ContentTypeContext::thereIsAContentTypeWithId()
When I go to "content/create/nodraft/folder/eng-GB/2" # EzSystems\EzPlatformContentForms\Behat\Context\ContentEditContext::visit()
Then I should see a folder content edit form # EzSystems\EzPlatformContentForms\Behat\Context\ContentEditContext::iShouldSeeAContentEditForm()
When I fill in the folder edit form # EzSystems\EzPlatformContentForms\Behat\Context\ContentEditContext::iFillInTheFolderEditForm()
And I press "Publish" # EzSystems\EzPlatformContentForms\Behat\Context\ContentEditContext::pressButton()
Then I am on the View of the Content that was published # EzSystems\EzPlatformContentForms\Behat\Context\ContentEditContext::iAmOnTheViewOfTheContentThatWasPublished()
Behat\Mink\Exception\ElementNotFoundException: Element matching css "span.ezstring-field" not found. in vendor/friends-of-behat/mink/src/WebAssert.php:418
```
Nattfarinn
approved these changes
Feb 1, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
konradoboza
approved these changes
Feb 2, 2023
ViniTou
approved these changes
Feb 2, 2023
webhdx
approved these changes
Feb 2, 2023
bogusez
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.ibexa.co/browse/IBX-4796
Publishing should redirect to a referrer Location now.