Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4486: Disabled Autosave feature for nodraft requests #66

Merged
merged 3 commits into from
Feb 9, 2023
Merged

IBX-4486: Disabled Autosave feature for nodraft requests #66

merged 3 commits into from
Feb 9, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Feb 7, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-4486
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Autosave shouldn't be enabled for nodraft requests.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 added Bug Something isn't working Ready for review labels Feb 7, 2023
@barw4 barw4 self-assigned this Feb 7, 2023
@barw4 barw4 mentioned this pull request Feb 7, 2023
Closed
2 tasks
@ViniTou ViniTou requested a review from a team February 8, 2023 09:52
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@barw4 barw4 requested a review from ViniTou February 8, 2023 11:57
@konradoboza konradoboza requested a review from a team February 8, 2023 12:06
@micszo micszo self-assigned this Feb 9, 2023
@micszo micszo mentioned this pull request Feb 9, 2023
Closed
micszo
micszo approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested successfully.

QA Approved on Ibexa Commerce 3.3.31-dev.

@micszo micszo removed their assignment Feb 9, 2023
@ViniTou ViniTou merged commit 39a1226 into 1.3 Feb 9, 2023
@ViniTou ViniTou deleted the ibx-4486-disable-autosave-nodraft branch February 9, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@Nattfarinn Nattfarinn

@webhdx webhdx

@ViniTou ViniTou

@barw4 barw4

Labels
Bug Something isn't working QA approved Ready for MERGE
Milestone
No milestone
6 participants
@barw4 @micszo @ViniTou @konradoboza @Nattfarinn @webhdx