Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6495: Fixed saving non-translatable fields in main language #74

Merged
merged 3 commits into from
Sep 28, 2023
Merged

IBX-6495: Fixed saving non-translatable fields in main language #74

merged 3 commits into from
Sep 28, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Sep 19, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6495
Type bug
Target Ibexa version v3.3
BC breaks no

An additional check was added to ensure that saving new non-translatable values in the same language as a main language won't be reverted.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 added Bug Something isn't working Ready for review labels Sep 19, 2023
@barw4 barw4 requested a review from a team September 19, 2023 13:30
@barw4 barw4 self-assigned this Sep 19, 2023
@webhdx webhdx requested a review from a team September 26, 2023 08:18
@barw4 barw4 requested a review from webhdx September 26, 2023 08:22
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx requested a review from a team September 26, 2023 08:26
@konradoboza konradoboza requested a review from a team September 26, 2023 13:34
tomaszszopinski
tomaszszopinski approved these changes Sep 28, 2023
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@webhdx webhdx merged commit d8c2f85 into 1.3 Sep 28, 2023
13 checks passed
@webhdx webhdx deleted the ibx-6495-fix-saving-nontranslatable-fields branch September 28, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webhdx webhdx webhdx approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@Nattfarinn Nattfarinn

@webhdx webhdx

@barw4 barw4

@konradoboza konradoboza

Labels
Bug Something isn't working QA approved
Milestone
No milestone
5 participants
@barw4 @webhdx @konradoboza @tomaszszopinski @Nattfarinn