Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31986: CompileAssetsCommand does not throw an exception when failing #19

Merged
merged 2 commits into from
Oct 6, 2020
Merged

EZP-31986: CompileAssetsCommand does not throw an exception when failing #19

merged 2 commits into from
Oct 6, 2020

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Oct 5, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31986
Bug/Improvement yes
New feature no
Target version 1.0, 2.1, master
BC breaks no
Tests pass yes
Doc needed no

JIRA excerpt:

Currently, CompileAssetsCommand throws no exception in case of e.g. syntax error. That results in a successfully finished build. Due to that, the site might be missing a manifest.json file that causes 500 error.

TODO:

  • Implement feature / fix a bug.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@konradoboza konradoboza self-assigned this Oct 5, 2020
@konradoboza konradoboza removed their assignment Oct 5, 2020
@konradoboza konradoboza force-pushed the ezp-31986-assets-compiling-no-error branch from e59a99a to 973c630 Compare October 5, 2020 11:47
tomaszszopinski
tomaszszopinski approved these changes Oct 6, 2020
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5.14 with patch & 2.5 with diff.

@lserwatka lserwatka merged commit 8b969f2 into 1.0 Oct 6, 2020
@lserwatka
Copy link
Member

You can merge it up.

@konradoboza konradoboza deleted the ezp-31986-assets-compiling-no-error branch October 6, 2020 10:44
@konradoboza
Copy link
Member Author

Done.

@adamwojs adamwojs mentioned this pull request Oct 15, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p left review comments

@lserwatka lserwatka lserwatka approved these changes

@adamwojs adamwojs adamwojs approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@alongosz alongosz Awaiting requested review from alongosz

@webhdx webhdx Awaiting requested review from webhdx

@dew326 dew326 Awaiting requested review from dew326

Assignees
No one assigned
Labels
Improvement Good for newcomers Ready for QA
Milestone
No milestone
5 participants
@konradoboza @lserwatka @adamwojs @Steveb-p @tomaszszopinski