EZP-32098: Provided backwards compatibility for removed ez-icons.svg #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
approved these changes
Oct 22, 2020
mnocon
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
I've reversed the changes from https://github.com/ezsystems/ezplatform-workflow/pull/168 to test whether the fallback to old icons is working.
Tested all the methods of installing assets (hardcopy, symlink, relative symlink) - all worked and the icons appeared as they should.
Albo performed a deployment on Platform.sh which succeeded.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterRemoving
ez-icons.svgfile from AdminUI could break 3rd party code. In order to provide backwards compatibility,AssetsInstallCommandSubscriberwill symlink/copy new file in oldez-icons.svgpath after usingassets:installcommand.TODO:
$ composer fix-cs).