Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped PHP requirement #51

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Bumped PHP requirement #51

merged 3 commits into from
Jan 5, 2022

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Dec 13, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-1489
Bug/Improvement yes
New feature no
Target version 2.3
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@konradoboza konradoboza marked this pull request as ready for review January 5, 2022 07:42
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza self-assigned this Jan 5, 2022
@adamwojs adamwojs merged commit de13b97 into 2.3 Jan 5, 2022
@adamwojs adamwojs deleted the bump-php-req branch January 5, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mnocon mnocon mnocon approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@konradoboza konradoboza

Labels
None yet
Milestone
No milestone
3 participants
@konradoboza @adamwojs @mnocon