Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1130: Add language argument to translatable fields #106

Merged
merged 1 commit into from
Nov 5, 2021
Merged

IBX-1130: Add language argument to translatable fields #106

merged 1 commit into from
Nov 5, 2021

Conversation

bdunogier
Copy link
Member

@bdunogier bdunogier commented Oct 8, 2021 •
edited

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-1130
Type feature
Target Ibexa DXP version v3.3.10
BC breaks no

New version of #56 for the 2.3 branch.

Gives more flexibility when querying multilingual content. As long as the current siteaccess is configured with several (or all) languages, multiple translations of each field can be obtained at once.

When no language is specified, the previous behaviour is maintained, and the most prioritized existing translation is used.

image

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage (kinda)
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adamwojs
adamwojs approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bdunogier
Copy link
Member Author

Ping @webhdx.

webhdx
webhdx approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was off for the past 2 weeks. PR is okay 👍

@bdunogier bdunogier mentioned this pull request Oct 21, 2021
Closed
@adamwojs adamwojs changed the title IBX-1130: add language argument to translatable fields IBX-1130: Add language argument to translatable fields Oct 21, 2021
@bdunogier bdunogier mentioned this pull request Oct 21, 2021
Merged
@DominikaK DominikaK added the Doc needed The changes require some documentation label Oct 22, 2021
kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes Nov 3, 2021
View reviewed changes
Copy link

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qa - approved

@adamwojs adamwojs merged commit b0ebbd9 into 2.3 Nov 5, 2021
@adamwojs adamwojs deleted the ibx1130-multilingual_fields branch November 5, 2021 13:43
@DominikaK DominikaK removed the Doc needed The changes require some documentation label Nov 8, 2021
@konradoboza konradoboza mentioned this pull request Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@webhdx webhdx webhdx approved these changes

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
5 participants
@bdunogier @adamwojs @webhdx @kacper-wieczorek-ibexa @DominikaK