IBX-1288: Skipped schema generation for invalid Content Type Group / Content Type and Field Definition #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Oct 19, 2021
Steveb-p
approved these changes
Oct 19, 2021
|
PR rebased agains current 1.0 + added commit with explicit logger config. |
…Content Type and Field Definition (according to GraphQL spec)
ViniTou
approved these changes
Oct 25, 2021
Steveb-p
requested changes
Oct 25, 2021
Comment on lines
+61
to
+65
| EzSystems\EzPlatformGraphQL\Schema\Domain\Content\ContentDomainIterator: | ||
| calls: | ||
| - method: setLogger | ||
| arguments: | ||
| - '@logger' |
There was a problem hiding this comment.
I'm pretty sure that is not necessary, as this is done via autoconfiguration - see FrameworkExtension in Symfony:
$container->registerForAutoconfiguration(LoggerAwareInterface::class)
->addMethodCall('setLogger', [new Reference('logger')]);There was a problem hiding this comment.
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
|
Kudos, SonarCloud Quality Gate passed!
|
alongosz
approved these changes
Oct 25, 2021
kacper-wieczorek-ibexa
approved these changes
Oct 25, 2021
|
You can merge it up and to ibexa/* |
|
Changed has been merge up to 2.3 and master. Tomorrow I will take care of merge to ibexa/*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #108 but for Content Type Group / Content Type and Field Definition