Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31113: AssignSectionToSubtreeSignal is not handled by search and HTTP cache #106

Merged
merged 8 commits into from Feb 3, 2020
Merged

EZP-31113: AssignSectionToSubtreeSignal is not handled by search and HTTP cache #106

merged 8 commits into from Feb 3, 2020

Conversation

kmadejski
Copy link
Member

@kmadejski kmadejski commented Nov 7, 2019 •
edited by andrerom

Question Answer
JIRA issue EZP-31113
Type Bug
Target version 0.9
BC breaks no
Doc needed no

This PR depends on: ezsystems/ezpublish-kernel#2862. Please refer to it for more information.

TODO:

  • Implement feature / fix a bug.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.
  • Drop changes on merge to master
  • Create a separated PR which uses events instead (for master).

@kmadejski kmadejski self-assigned this Nov 7, 2019
@micszo micszo self-assigned this Nov 12, 2019
alongosz
alongosz requested changes Nov 12, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First and foremost you need to bump kernel requirement. There's also this issue that 0.9 allows both 6.13 and 7.5, which no longer makes sense. It happens when you introduce features to LTS branches :P
I would go for 0.10 for eZ Platform 2.5.next.

src/SignalSlot/SectionService/AssignSectionToSubtreeSlot.php Show resolved Hide resolved
micszo
micszo approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ezsystems/ezplatform-solr-search-engine#160.

@micszo micszo removed their assignment Nov 25, 2019
@adamwojs adamwojs mentioned this pull request Nov 27, 2019
Merged
5 tasks
@andrerom andrerom changed the base branch from 0.9 to 1.0 January 30, 2020 20:10
@andrerom andrerom mentioned this pull request Jan 31, 2020
Closed
4 tasks
@andrerom andrerom merged commit 1a503b8 into ezsystems:1.0 Feb 3, 2020
@andrerom andrerom mentioned this pull request Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom approved these changes

@alongosz alongosz alongosz requested changes

@lserwatka lserwatka lserwatka approved these changes

@adamwojs adamwojs adamwojs approved these changes

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

Assignees

@kmadejski kmadejski

Labels
Bug QA approved
Milestone
No milestone
7 participants
@kmadejski @lserwatka @adamwojs @andrerom @alongosz @micszo @ViniTou