Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31603: Fixed trusted proxy check #129

Merged
merged 1 commit into from Apr 29, 2020
Merged

EZP-31603: Fixed trusted proxy check #129

merged 1 commit into from Apr 29, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Apr 27, 2020 •
edited

Question Answer
JIRA issue EZP-31603
Type Bug
Target version 2.0
BC breaks no
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ViniTou ViniTou changed the base branch from master to 2.0 April 27, 2020 09:38
@ViniTou ViniTou requested a review from a team April 27, 2020 09:43
@mnocon mnocon self-assigned this Apr 27, 2020
@alongosz alongosz mentioned this pull request Apr 27, 2020
Merged
5 tasks
@ViniTou ViniTou mentioned this pull request Apr 28, 2020
Merged
@ViniTou ViniTou force-pushed the EZP-31603-fix-trusted-proxy-check branch from 332c76c to 43e53eb Compare April 29, 2020 07:56
mnocon
mnocon approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 together with ezsystems/ezplatform#537

@lserwatka lserwatka merged commit 5e87396 into 2.0 Apr 29, 2020
@lserwatka
Copy link
Member

Could you merge it up?

@lserwatka lserwatka deleted the EZP-31603-fix-trusted-proxy-check branch April 29, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom approved these changes

@alongosz alongosz alongosz approved these changes

@mnocon mnocon mnocon approved these changes

Assignees

@mnocon mnocon

Labels
None yet
Milestone
No milestone
5 participants
@ViniTou @lserwatka @andrerom @alongosz @mnocon