Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-27458: Restructured Aggregation API integration tests #129

Merged
merged 1 commit into from
Nov 2, 2020
Merged

EZP-27458: Restructured Aggregation API integration tests #129

merged 1 commit into from
Nov 2, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 25, 2020 •
edited

Question Answer
JIRA issue EZP-27458
Type improvement
Target eZ Platform version v3.x
BC breaks no
Doc needed no

Follow up for #94.

Restructured Aggregation API integration tests as promised in #94 (comment) and #94 (comment) 😉

  • SearchServiceAggregationTest::createTermAggregationTestCase logic has been moved to \eZ\Publish\API\Repository\Tests\SearchService\Aggregation\DataSetBuilder\TermAggregationDataSetBuilder (dateset is term used by PHPUnit documentation for single data provider item)
  • SearchServiceAggregationTest::createFieldAggregationFixtures and SearchServiceAggregationTest::createContentTypeForFieldAggregation logic has been moved to \eZ\Publish\API\Repository\Tests\SearchService\Aggregation\FixtureGenerator\FieldAggregationFixtureGenerator
  • Each aggregation is a separate test class

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 44 Code Smells

No Coverage information No Coverage information
10.9% 10.9% Duplication

@adamwojs adamwojs requested a review from a team October 26, 2020 12:40
@adamwojs adamwojs self-assigned this Oct 26, 2020
@adamwojs adamwojs added the Improvement Changes not fixing or changing behavior label Oct 26, 2020
@adamwojs adamwojs marked this pull request as ready for review October 26, 2020 12:41
@adamwojs adamwojs mentioned this pull request Oct 26, 2020
Merged
alongosz
alongosz approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming Travis fails because of the dependency on the Solr Bundle counterpart PR.

@adamwojs adamwojs changed the base branch from master to 1.2 October 30, 2020 08:53
@adamwojs
Copy link
Member Author

adamwojs commented Nov 2, 2020

CI is passing now: https://travis-ci.com/github/ezsystems/ezplatform-kernel/jobs/407011420

@adamwojs adamwojs merged commit 80573a6 into 1.2 Nov 2, 2020
@adamwojs adamwojs deleted the aggs_tests_refactoring branch November 2, 2020 20:50
Steveb-p pushed a commit that referenced this pull request Sep 27, 2022
Fixed wrong PHPDoc param declaration for FieldHelper::isFieldEmpty …
6683f14 
…method (#129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@adamwojs adamwojs

Labels
Improvement Changes not fixing or changing behavior
Milestone
No milestone
3 participants
@adamwojs @Steveb-p @alongosz