-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-32107: Added Score sort clause #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. I have code analysis related request. While this might seem unimportant, the reason for doing such changes is DX of future updates. We either can disable a rule or follow it strictly, so when code analysis reports an issue I know it comes from my code, not from the past changes.
PR updated according to code review suggestions. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with ES and Solr, looks good!
v3.3
Added
\eZ\Publish\API\Repository\Values\Content\Query\SortClause\Score
which allows explicitly define sorting by relevance score. Typical use case for\eZ\Publish\API\Repository\Values\Content\Query\SortClause\Score
is composition of multiple sort clauses:\eZ\Publish\API\Repository\Values\Content\Query\SortClause\Score
by engines which are capable of scoring results (Solr and ES)Checklist:
$ composer fix-cs
).@ezsystems/php-dev-team
).