Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3356: Added JsonSerializableNormalizer for Serializer to handle Serializable interface #136

Merged
merged 1 commit into from
Nov 24, 2020
Merged

EZEE-3356: Added JsonSerializableNormalizer for Serializer to handle Serializable interface #136

merged 1 commit into from
Nov 24, 2020

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Nov 17, 2020 •
edited

Question Answer
JIRA issue EZEE-3356
Type bug
Target eZ Platform version v3.1
BC breaks no
Doc needed no
Related PR https://github.com/ezsystems/ezplatform-site-factory/pull/100

JsonSerializableNormalizer needs to be added to deal with objects implementing the JsonSerializable interface.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@mikadamczyk mikadamczyk added the Bug Something isn't working label Nov 17, 2020
@mikadamczyk mikadamczyk self-assigned this Nov 17, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo self-assigned this Nov 19, 2020
@micszo micszo removed their assignment Nov 24, 2020
@lserwatka lserwatka merged commit 80782cd into 1.1 Nov 24, 2020
@lserwatka lserwatka deleted the EZEE-3356 branch November 24, 2020 08:03
@lserwatka
Copy link
Member

You can merge it up.

Steveb-p pushed a commit that referenced this pull request Sep 27, 2022
@adamwojs
Merge pull request #136 from ibexa/temp_1.3_to_4.1
1bc99c3 
Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@kaff kaff Awaiting requested review from kaff

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@mikadamczyk mikadamczyk

Labels
Bug Something isn't working QA approved
Milestone
No milestone
7 participants
@mikadamczyk @lserwatka @adamwojs @Steveb-p @alongosz @micszo @ViniTou