Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32181: Exposed Site Access Limitation type persistence value generation #139

Merged
merged 1 commit into from
Dec 31, 2020
Merged

EZP-32181: Exposed Site Access Limitation type persistence value generation #139

merged 1 commit into from
Dec 31, 2020

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Dec 1, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-32181
Type improvement
Target eZ Platform version v3.3
BC breaks no
Doc needed no

This PR exposes currently internal eZ\Publish\Core\Limitation\SiteAccessLimitationType::generateSiteAccessValue.
It is needed for tools like ezmigration, which duplicates the implementation in places where mapping between value stored in persistence is needed to be mapped to an existing SiteAccess.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@Steveb-p Steveb-p requested review from alongosz and a team December 1, 2020 07:06
@alongosz alongosz changed the title EZP-31309: Expose site access limitation type persistence value generation EZP-31309: Exposed site access limitation type persistence value generation Dec 1, 2020
@Steveb-p Steveb-p changed the title EZP-31309: Exposed site access limitation type persistence value generation EZP-32181: Exposed site access limitation type persistence value generation Dec 1, 2020
@alongosz alongosz changed the title EZP-32181: Exposed site access limitation type persistence value generation EZP-31309: Exposed Site Access Limitation type persistence value generation Dec 1, 2020
@Steveb-p Steveb-p changed the title EZP-31309: Exposed Site Access Limitation type persistence value generation EZP-32181: Exposed Site Access Limitation type persistence value generation Dec 1, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz merged commit 9c70272 into master Dec 31, 2020
@alongosz alongosz deleted the site-access-value branch December 31, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Steveb-p @mikadamczyk @alongosz